Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Test Coverage #104

Closed
marvin-hansen opened this issue Sep 21, 2023 · 4 comments
Closed

Increase Test Coverage #104

marvin-hansen opened this issue Sep 21, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@marvin-hansen
Copy link
Member

marvin-hansen commented Sep 21, 2023

Currently, the core library is reasonable tested but some gaps exists.

The easiest way to get started:

  1. Check the code coverage report:
    https://app.codecov.io/gh/deepcausality-rs/deep_causality

  2. See where some gaps are

  3. Look at the existing tests. Most are easy to copy & modify.
    https://github.com/deepcausality-rs/deep_causality/tree/main/deep_causality/tests

  4. Add some new tests. Make sure you run make test & make check before before opening a PR.
    See details for make in the BUILD document.

  5. Make a PR and wait for review

@marvin-hansen marvin-hansen added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 21, 2023
@MeenuyD
Copy link

MeenuyD commented Sep 21, 2023

Hello @marvin-hansen I would like to work on this issue can you please assign it to me?

@marvin-hansen
Copy link
Member Author

Absolutely! Thank you @MeenuyD

@marvin-hansen marvin-hansen pinned this issue Sep 21, 2023
@marvin-hansen
Copy link
Member Author

@MeenuyD Make sure you read the build doc before you get started coding because it contains all the infos about the make automation scripts.

Thank you for your contribution.

@marvin-hansen
Copy link
Member Author

@marvin-hansen marvin-hansen unpinned this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants