We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format/webrtc3/adapter.go and format/webrtc/adapter.go assume that the SDP message is base-64 encoded.
format/webrtc3/adapter.go
format/webrtc/adapter.go
func (element *Muxer) WriteHeader(streams []av.CodecData, sdp64 string) (string, error) { ... sdpB, err := base64.StdEncoding.DecodeString(sdp64)
However, I do not think this is required in the specifications.
I see that RTSPtoWebRTC/web/static/js/app.js uses this encoding as well. Perhaps the encoding could be isolated to only the RTSPtoWebRTC project?
RTSPtoWebRTC/web/static/js/app.js
RTSPtoWebRTC
If it is not required by the relevant specifications, I think this encoding should be optional / configurable, or removed entirely.
The text was updated successfully, but these errors were encountered:
This was in the previous PION example. I think this is not necessary at all.
Sorry, something went wrong.
deepch
No branches or pull requests
format/webrtc3/adapter.go
andformat/webrtc/adapter.go
assume that the SDP message is base-64 encoded.However, I do not think this is required in the specifications.
I see that
RTSPtoWebRTC/web/static/js/app.js
uses this encoding as well. Perhaps the encoding could be isolated to only theRTSPtoWebRTC
project?If it is not required by the relevant specifications, I think this encoding should be optional / configurable, or removed entirely.
The text was updated successfully, but these errors were encountered: