Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base-64 encoding of SDP optional #20

Open
travishaagen opened this issue Apr 16, 2021 · 1 comment
Open

Make base-64 encoding of SDP optional #20

travishaagen opened this issue Apr 16, 2021 · 1 comment
Assignees

Comments

@travishaagen
Copy link
Contributor

travishaagen commented Apr 16, 2021

format/webrtc3/adapter.go and format/webrtc/adapter.go assume that the SDP message is base-64 encoded.

func (element *Muxer) WriteHeader(streams []av.CodecData, sdp64 string) (string, error) {
	...
	sdpB, err := base64.StdEncoding.DecodeString(sdp64)

However, I do not think this is required in the specifications.

I see that RTSPtoWebRTC/web/static/js/app.js uses this encoding as well. Perhaps the encoding could be isolated to only the RTSPtoWebRTC project?

If it is not required by the relevant specifications, I think this encoding should be optional / configurable, or removed entirely.

@deepch
Copy link
Owner

deepch commented May 9, 2021

This was in the previous PION example. I think this is not necessary at all.

@deepch deepch self-assigned this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants