Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEE-6] [FEAT] Better error message when passing illegal columns to _DummyModel #2206

Open
noamzbr opened this issue Dec 18, 2022 · 0 comments
Labels
feature Feature update or code change to the package good first issue Good for newcomers
Milestone

Comments

@noamzbr
Copy link
Collaborator

noamzbr commented Dec 18, 2022

Is your feature request related to a problem? Please describe.
As raised by @OlivierBinette in #2202, sklearn models can run correctly when supplied with additional columns (on top of the feature columns), while _DummyModel must receive exactly the feature columns. This may lead to confusion when implementing custom checks, as users may expect context.model.predict(dataset.data) to work.

Describe the solution you'd like
In these cases, the _DummyModel should raise an error explaining it expects to receive exactly the feature columns, and no more.

DEE-6

@github-actions github-actions bot added the needs triage Issue needs to be labeled and prioritized label Dec 18, 2022
@noamzbr noamzbr added feature Feature update or code change to the package good first issue Good for newcomers and removed needs triage Issue needs to be labeled and prioritized labels Dec 18, 2022
@noamzbr noamzbr added this to the Newton milestone Jan 1, 2023
@ItayGabbay ItayGabbay changed the title [FEAT] Better error message when passing illegal columns to _DummyModel [DEE-6] [FEAT] Better error message when passing illegal columns to _DummyModel Jan 11, 2023
@ItayGabbay ItayGabbay removed the linear label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants