Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CV] ClassPerformance can't accept list in alternative_scorers #895

Closed
noamzbr opened this issue Feb 20, 2022 · 0 comments · Fixed by #907
Closed

[BUG] [CV] ClassPerformance can't accept list in alternative_scorers #895

noamzbr opened this issue Feb 20, 2022 · 0 comments · Fixed by #907
Assignees
Labels
Milestone

Comments

@noamzbr
Copy link
Collaborator

noamzbr commented Feb 20, 2022

Describe the bug
The parameter alternative_scorers of ClassPerformance is documented as needing to be a list (and is tested to be a list) but the actual code using it assumes it's a dict {name: metric}, like the outputs of get_default_classification_scorers for e.g.

To Reproduce
Run ClassPerformance with alternative_scorers=[SomeMetric]

Expected behavior
alternative_scorers should work, with one option only (probably list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants