Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 整合prometheus #11

Merged
merged 8 commits into from
Feb 24, 2020
Merged

feat: 整合prometheus #11

merged 8 commits into from
Feb 24, 2020

Conversation

Jammyson
Copy link
Contributor

整合prometheus

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #11 into master will decrease coverage by 2.26%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage    98.4%   96.13%   -2.27%     
==========================================
  Files          23       24       +1     
  Lines         251      259       +8     
==========================================
+ Hits          247      249       +2     
- Misses          4       10       +6
Impacted Files Coverage Δ
generators/app/index.js 97.29% <ø> (ø) ⬆️
generators/app/handler/configurer/configurers.js 97.05% <ø> (ø) ⬆️
...rs/app/handler/configurer/prometheus_configurer.js 25% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392459e...794f7f9. Read the comment docs.

@taccisum
Copy link
Collaborator

需要提供单元测试和可选参数

@taccisum
Copy link
Collaborator

以及相应文档

generators/app/index.js Outdated Show resolved Hide resolved
generators/test/app/index.test.js Outdated Show resolved Hide resolved
@taccisum taccisum merged commit db297a5 into deepexi:master Feb 24, 2020
xiangtch added a commit to xiangtch/generator-deepexi-spring-cloud that referenced this pull request Feb 25, 2020
feat: support integration with prometheus(deepexi#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants