Added ability to change text color of the help text #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torzdf
requested changes
Sep 24, 2020
There was a problem hiding this comment.
Sorry it's taken me so long to get around to this....
And also, I'm going to make you change it. I hadn't really looked at the original issue too much. It seems that the foreground color should always be black, rather than user selectable, so the config stuff isn't really necessary (sorry about that!).
If you can make the following changes, I'll merge.
Comment on lines
+59
to
+62
| self.add_item( | ||
| section=section, title="text_color", datatype=str, | ||
| choices=["black", "red", "green", "blue", "yellow"], | ||
| default="black", group="font", info="Help text color.") |
| @@ -7,6 +7,7 @@ | |||
| import sys | |||
| import tkinter as tk | |||
| from tkinter import ttk, TclError | |||
| from matplotlib import colors | |||
torzdf
reviewed
Sep 24, 2020
| @@ -571,6 +572,7 @@ def __init__(self, widget, *, background="#FFFFEA", pad=(5, 3, 5, 3), text="widg | |||
| self._widget.bind("<ButtonPress>", self._on_leave) | |||
| self._background = background | |||
| self._pad = pad | |||
| self._textcolor = colors.cnames[get_config().user_config_dict["text_color"]] | |||
There was a problem hiding this comment.
New optional parameter in Tooltip.__init__()
foreground="#000000,Then referenced here.
self._foreground = foreground
torzdf
reviewed
Sep 24, 2020
| @@ -662,6 +664,7 @@ def tip_pos_calculator(widget, label, | |||
| text=self._text, | |||
| justify=tk.LEFT, | |||
| background=background, | |||
| foreground=self._textcolor, | |||
There was a problem hiding this comment.
foreground=self._foreground,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #1047
I added the option to change the font color of the help text.