Add empty state feedback and animation to scanning process - Updates #4 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Le-Roi777 Good stuff! Thanks for the PR. I'll review it. |
ibreakthecloud
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Add blank slate and loading animation #4
Added a loading state in the App component and passed it to the table components as prop (loadingRows). In the table component the following have been added to accommodate feedback for the scanning process.
Added text feedback and loading indicator to the table component when rows are loading.
Added initial state placeholder with an icon and text when no scan has been initialized. (if we don't have a response/rows).
Added no results found feedback with an icon and text when the scan results are empty. (if we don't have a response/rows).
Updates update README with development steps #3
I also updated the README with development instructions : - )