Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyright type definitions check fails with upgrade to 3.1.5 #327

Closed
noxan opened this issue Feb 29, 2024 · 3 comments
Closed

Pyright type definitions check fails with upgrade to 3.1.5 #327

noxan opened this issue Feb 29, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@noxan
Copy link

noxan commented Feb 29, 2024

What is the current behavior?

  • Upgraded from 3.1.4 to 3.1.5 and pyright fails
  • Cannot access member "v" for type "LiveClient". Member "v" is unknown. Pylance[reportAttributeAccessIssue]

Steps to reproduce

  • Upgraded from 3.1.4 to 3.1.5 and pyright fails
  • Use regular example (same for async client by the way)

Expected behavior

  • It should not report any issues like it did before
@dvonthenen
Copy link
Contributor

Apparently, pyright doesnt like the Union of multiple return types because the classes are dynamically returned. This was done in an effort to fix this issue: #311. Will selectively revert some changes, but someone is going to be unhapp. Will need to investigate how to handle this.

@dvonthenen dvonthenen self-assigned this Feb 29, 2024
@dvonthenen dvonthenen added the bug Something isn't working label Feb 29, 2024
@dvonthenen
Copy link
Contributor

Fixed in this release:
https://github.com/deepgram/deepgram-python-sdk/releases/tag/v3.1.6

@noxan
Copy link
Author

noxan commented Mar 1, 2024

thanks @dvonthenen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants