Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added getKey to SelectionUtils.optimizeSelection #1994

Merged
merged 1 commit into from May 7, 2024
Merged

fix: Added getKey to SelectionUtils.optimizeSelection #1994

merged 1 commit into from May 7, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented May 7, 2024 •
edited

fixes root issue of DH-16914

I published this as an alpha for DHE testing:
0.76.1-alpha-optimize-selection-get-key.0

BREAKING CHANGE: @deephaven/react-hooks: SelectionUtils.optimizeSelection and useMappedSelection require additional getKey arg

@bmingles bmingles requested a review from vbabich May 7, 2024 22:17
@bmingles bmingles merged commit 4404894 into deephaven:main May 7, 2024
11 checks passed
@bmingles bmingles deleted the 1993-optimize-selection-get-key branch May 7, 2024 22:38
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@bmingles bmingles linked an issue May 7, 2024 that may be closed by this pull request
DH-16914: optimizeSelection needs getKey function #1993
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vbabich vbabich vbabich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DH-16914: optimizeSelection needs getKey function
2 participants
@bmingles @vbabich