Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And rational behind choosing the arc loss zy_keep value #108

Closed
zhenglaizhang opened this issue Mar 14, 2018 · 3 comments
Closed

And rational behind choosing the arc loss zy_keep value #108

zhenglaizhang opened this issue Mar 14, 2018 · 3 comments

Comments

@zhenglaizhang
Copy link

Hi, after reading the code, I didn't understand why the specific value zy_keep is chosen, could you help share some inghts here? thanks in advance!

zy_keep = zy - s*mm

mm = math.sin(math.pi-m)*m
...
zy_keep = zy - s*mm
@nttstar
Copy link
Collaborator

nttstar commented Mar 14, 2018

To make the function cos(theta+m) monotonic decreasing while theta in [0°,180°]. But actually it's not necessary as theta will not go much larger than 90°.

@nttstar nttstar closed this as completed Mar 20, 2018
@douhaoexia
Copy link

Hello, I have some doubt.
From the code , I know when theta > threshold, ' cos(theta+m)' will be changed to zy_keep , namely 'cos(theta)-msin(m)'. The min of cos(theta+m) is -1 . To make the function monotonic decreasing while theta in [0°,180°] , we need to make sure ' cos(theta)-msin(m) < = -1' when ' theta > pi - m ' .
However, I can't prove 'cos(theta)-m*sin(m) < = -1' . Any problem about my analysis?

@siahewei
Copy link

siahewei commented May 21, 2018

image

@douhaoexia above figure, when m = 0.5 , as @nttstar said zy or zy_keep decreasing while theta in [0°,180°]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants