Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot 3.2.x requires at least Java 17 #38

Open
tzolov opened this issue Jan 24, 2024 · 1 comment
Open

Spring Boot 3.2.x requires at least Java 17 #38

tzolov opened this issue Jan 24, 2024 · 1 comment

Comments

@tzolov
Copy link
Contributor

tzolov commented Jan 24, 2024

Spring Boot 3.2.x requires at least Java 17 and is compatible up to and including Java 21.

The #35 updated Boot to 3.2.1 but on merge the JDK was reverted to 11. This likely an incompatible combination!

IMO, you should either (1) revert Boot to the latest 2.x version or (2) bring JDK to 17.

But with JDK 11/Boot 2.x, I'm not sure if this wont cause compatibility problems for Boot 3.x applications that are trying to use djl 11/2.x auto-config dependencies.

The safest option if you MUST support JDK 11 is to maintain and release two separate branches one for JDK11 and another JDK17?

Let me know what do you think?

@zachgk
Copy link
Contributor

zachgk commented Jan 24, 2024

Java is backwards compatible so it shouldn't cause problems. If we build a binary targeting JDK 11, it should be compatible with all versions >= 11 which should include the 17-21 supported by Spring Boot 3.2.x. The Spring Boot 3.2.x just means that at least some of the components as part of it require Java 17 so it must be run with Java >=17. It shouldn't mean that all components have to be.

Have you tried running it with the current Java 11 build and it fails or is this just a problem you are afraid will happen based on the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants