Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator: Client incorrectly including type data in function call #9

Closed
mcristina422 opened this issue May 10, 2019 · 1 comment
Closed

Generator: Client incorrectly including type data in function call #9

mcristina422 opened this issue May 10, 2019 · 1 comment

Comments

@mcristina422
Copy link

The generator is incorrectly including the type with the params variable
https://github.com/deepmap/oapi-codegen/blob/4a20c3b46839ade4181806ab37645d8ed46ccc15/pkg/codegen/templates/client.tmpl#L46

*{{$opid}}Params should be removed. I dont think this is covered in any generated tests yet
deepmap-marcinr pushed a commit that referenced this issue May 10, 2019
Fix extraneous params type specification
537846b 
This fixes issue #9. The function call generated in the case of
having a query argument and response body was incorrect. Added a
test case and fix.
@deepmap-marcinr
Copy link
Contributor

Fixed in commit 537846b

adrianpk pushed a commit to foorester/oapi-codegen that referenced this issue Jan 16, 2024
Fix extraneous params type specification
0130cea 
This fixes issue oapi-codegen#9. The function call generated in the case of
having a query argument and response body was incorrect. Added a
test case and fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcristina422 @deepmap-marcinr