AndroidEnv Example Tasks doc: fix download UI for APK/textproto ZIP files in dark mode #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-gergely , maybe we could use another icon that works well with a dark theme, but for now I think @8bitmp3's solution is more accessible, so I'll accept and merge this PR. |
|
@kenjitoyama @a-gergely Thank you. I've looked at other icons in the Material design library but couldn't find anything suitable for GitHub's dark mode UI. |
|
@8bitmp3, yeah, I also took a quick look and couldn't find anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download buttons for APK/textproto ZIP files are barely visible in GitHub web UI's dark mode, so they may be hard to find:
A simple solution could be just to have the word "Download" - it renders well in Markdown:
Hope this helps 馃憤