Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_gamma to the augmentation functions #48

Merged
merged 1 commit into from Oct 4, 2022

Conversation

alonfnt
Copy link
Contributor

@alonfnt alonfnt commented Oct 1, 2022

Since I have several projects where I have used this wrapper, and following on #43, I thought it would be okay to submit it as a PR to have it already in PIX.

random_gamma is just a wrapper for adjust_gamma where the value of the gamma parameter is sampled uniformly in the given range, similarly to what other augmentation functions already do in the library.

@claudiofantacci
Copy link
Collaborator

Hey @alonfnt, thanks a lot for the contributions!
I've triggered a bunch of test and will be back to you as soon as possible.

@alonfnt alonfnt force-pushed the random_gamma branch 2 times, most recently from d954283 to 637e629 Compare October 3, 2022 19:32
@alonfnt
Copy link
Contributor Author

alonfnt commented Oct 3, 2022

Hi @claudiofantacci, sorry for the confusion but apparently my branch was not up to date with upstream.
Now it should have the reference_fn argument correctly written and it is passing the test locally :)

@claudiofantacci claudiofantacci self-assigned this Oct 4, 2022
Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry for this new function in https://github.com/deepmind/dm_pix/blob/master/docs/api.rst 😄

dm_pix/__init__.py Outdated Show resolved Hide resolved
random_gamma is just a wrapper for `adjust_gamma` where the value of the
gamma parameter is sampled uniformly in the given range, similarly to
what other augmentation functions already do in the library.
Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🚀
I will take it from here, no need for any other action 👍

@copybara-service copybara-service bot merged commit 933e3ff into google-deepmind:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants