Implement calculations in periodic boundary conditions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the feature layer, envelope, and Hamiltonian described in ```Cassella, G., Sutterud, H., Azadi, S., Drummond, N.D., Pfau, D., Spencer, J.S. and Foulkes, W.M.C., 2022. Discovering Quantum Phase Transitions with Fermionic Neural Networks. arXiv preprint arXiv:2202.05183.``` Several changes to the configuration interface for feature layers and envelopes have been made. These are now specified by an interface similar to the local energy function. These changes, and the new periodic boundary conditions, are demonstrated in `ferminet.configs.heg`.
jsspencer
approved these changes
Jun 30, 2022
Default to lattice=None, and instance ndim*ndim identity in this case
jsspencer
requested changes
Jul 1, 2022
|
I think that addresses all of the comments - thank you for taking the time to go through everything and make clear recommendations 😄 |
jsspencer
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the feature layer, envelope, and Hamiltonian described in
Several changes to the configuration interface for feature layers and envelopes have been made. These are now specified by an interface similar to the local energy function. These changes, and the new periodic boundary conditions, are demonstrated in
ferminet.configs.heg.Other miscellaneous changes:
pylintstep of the GitHub CI workflow to9.75/10.0. This prevents the CI from failing over linting errors that are acceptable under the in-house style.