Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua 5.2 causes tests to fail #24

Closed
jagapiou opened this issue Mar 17, 2022 · 1 comment
Closed

Lua 5.2 causes tests to fail #24

jagapiou opened this issue Mar 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jagapiou
Copy link
Member

e.g. https://github.com/deepmind/meltingpot/actions/runs/1999939516

Until this is fixed better to use Lua 5.1 rather than Lua 5.2. This may have an impact on building Melting Pot on Apple M1 chips, see #13.

@jagapiou jagapiou added the bug Something isn't working label Mar 17, 2022
@jagapiou jagapiou self-assigned this Mar 17, 2022
copybara-service bot pushed a commit that referenced this issue Mar 17, 2022
Tests failing when things are built with Lua 5.2. See #24

Reverting here to unblock the CI pipeline.

PiperOrigin-RevId: 435394996
Change-Id: I9d2244e3759f6eb3f701a92f5f2fed0e72934b46
@jagapiou jagapiou pinned this issue Mar 17, 2022
@jagapiou jagapiou assigned duenez and unassigned jagapiou Jul 22, 2022
@jagapiou
Copy link
Member Author

Specifically the error is:

self = <dmlab2d.Environment object at 0x15f0bfa90>
    def reset(self):
      """See base class."""
      self._reset_next_step = False
>     self._env.start(self._next_episode, seed=self._rng.randint(0, 2**31))
E     ValueError: Failed to start: 
E     ERROR: ./meltingpot/lua/modules/component_library.lua:261: Error: Must call Transform:start(...) before Transform:getPiece().
E     stack trace-back:
E     ERROR: [C]: in function 'assert'
E     ERROR: @./meltingpot/lua/modules/component_library.lua:261:
E     ERROR: @/Users/runner/work/meltingpot/meltingpot/meltingpot/lua/levels/commons_harvest/components.lua:143: in function 'start'
E     ERROR: @./meltingpot/lua/modules/game_object.lua:423: in function 'func'
E     ERROR: @./meltingpot/lua/modules/game_object.lua:160: in function '_doOnAllComponents'
E     ERROR: @./meltingpot/lua/modules/game_object.lua:420: in function 'start'
E     ERROR: @./meltingpot/lua/modules/base_simulation.lua:465: in function 'start'
E     ERROR: @./meltingpot/lua/modules/api_factory.lua:100:

@jagapiou jagapiou unpinned this issue Nov 11, 2022
@jagapiou jagapiou pinned this issue Nov 26, 2022
@jagapiou jagapiou unpinned this issue Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants