Merge pull request #113 from dan-zheng:fix-swift-tests

PiperOrigin-RevId: 281540491 Change-Id: Ib3bf1ae3fece0f664dc13da23df69a077c883665
google-deepmind · Nov 20, 2019 · 3828e7d · 3828e7d
2 parents 07eaa29 + 594c9be
commit 3828e7d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/swift/Sources/OpenSpiel/ExploitabilityDescent.swift b/swift/Sources/OpenSpiel/ExploitabilityDescent.swift
@@ -215,7 +215,10 @@ public struct ActionValueCalculator<Game: GameProtocol> {
   }
 
   /// The exploitability descent loss for a policy.
-  @differentiable(wrt: policy)
+  // @differentiable(wrt: policy)
+  // NOTE: `@differentiable` attribute is commented because differentiation does not yet support
+  // `inout` arguments. https://bugs.swift.org/browse/TF-129 tracks `inout` argument
+  // differentiation support.
   public mutating func loss(for policy: TensorFlowTabularPolicy<Game>) -> Double {
     let (nashConv0, qValues0, counterfactualReachProbabilities0) =
       actionValuesAgainstBestResponder(

diff --git a/swift/Tests/OpenSpielTests/ExploitabilityDescentTests.swift b/swift/Tests/OpenSpielTests/ExploitabilityDescentTests.swift
@@ -23,6 +23,9 @@ final class ExploitabilityDescentTests: XCTestCase {
     var logitTable = TensorFlowLogitTable(informationStateCache)
     var actionValueCalculator = ActionValueCalculator(informationStateCache)
     var nashConvs: [Double] = []
+#if false
+    // NOTE: Test is disabled because differentiation does not yet support `inout` arguments.
+    // https://bugs.swift.org/browse/TF-129 tracks `inout` argument differentiation support.
     for _ in 0...10 {
       let gradients = gradient(at: logitTable) {
         (logitTable: TensorFlowLogitTable) -> Double in
@@ -39,6 +42,7 @@ final class ExploitabilityDescentTests: XCTestCase {
       0.30925081512398128, 0.28827843035940964, 0.26830042206858751,
       0.24418597846799289, 0.22168699344791482
     ]).forEach { XCTAssertEqual($0, $1, accuracy: 1e-5) }
+#endif
   }
 
   func testLeducPokerConvergence() throws {
@@ -48,6 +52,9 @@ final class ExploitabilityDescentTests: XCTestCase {
     var logitTable = TensorFlowLogitTable(informationStateCache)
     var actionValueCalculator = ActionValueCalculator(informationStateCache)
     var nashConvs: [Double] = []
+#if false
+    // NOTE: Test is disabled because differentiation does not yet support `inout` arguments.
+    // https://bugs.swift.org/browse/TF-129 tracks `inout` argument differentiation support.
     for _ in 0...10 {
       let gradients = gradient(at: logitTable) {
         (logitTable: TensorFlowLogitTable) -> Double in
@@ -62,6 +69,7 @@ final class ExploitabilityDescentTests: XCTestCase {
       4.7472224, 4.3147216, 3.9900389, 3.7576618, 3.5771275, 3.4414644,
       3.3272073, 3.1898201, 3.1089299, 3.0108435, 2.8992782
     ]).forEach { XCTAssertEqual($0, $1, accuracy: 1e-5) }
+#endif
   }
 }