Compile error in docker

[ekaradon-Alexander]

Host OS:

• macOS Catalina 10.15.6
• Docker 19.03.12

Run command:

docker build --target base -t openspiel . --rm

Error message:

Step 17/30 : RUN make -j12
...
...
In file included from /repo/open_spiel/game_parameters.cc:15:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^
/repo/open_spiel/../open_spiel/game_parameters.h:121:10: error: explicit specialization of 'value' in class scope
  double value() const {
         ^
/repo/open_spiel/../open_spiel/game_parameters.h:125:22: error: explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/repo/open_spiel/../open_spiel/game_parameters.h:129:15: error: explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/repo/open_spiel/../open_spiel/game_parameters.h:133:8: error: explicit specialization of 'value' in class scope
  bool value() const {
       ^
/repo/open_spiel/../open_spiel/game_parameters.h:137:47: error: explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/repo/open_spiel/../open_spiel/game_parameters.h:141:40: error: explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
In file included from In file included from /repo/open_spiel/fog/observation_history.cc:15:
In file included from /repo/open_spiel/../open_spiel/fog/observation_history.h:24:
In file included from /repo/open_spiel/../open_spiel/spiel.h:36:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^
/repo/open_spiel/../open_spiel/game_parameters.h:121:10: error: explicit specialization of 'value' in class scope
  double value() const {
         ^
/repo/open_spiel/../open_spiel/game_parameters.h:125:22: error: explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/repo/open_spiel/../open_spiel/game_parameters.h:129:15: error: explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/repo/open_spiel/../open_spiel/game_parameters.h:133:8: error: explicit specialization of 'value' in class scope
  bool value() const {
       ^
/repo/open_spiel/../open_spiel/game_parameters.h:137:47: error: explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/repo/open_spiel/../open_spiel/game_parameters.h/repo/open_spiel/observer.cc:141:40: error: explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
:                                       ^
22:
In file included from /repo/open_spiel/../open_spiel/spiel.h:36:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^
/repo/open_spiel/../open_spiel/game_parameters.h:121:10: error: explicit specialization of 'value' in class scope
  double value() const {
         ^
/repo/open_spiel/../open_spiel/game_parameters.h:125:22: error: explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/repo/open_spiel/../open_spiel/game_parameters.h:129:15: error: explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/repo/open_spiel/../open_spiel/game_parameters.h:133:8: error: explicit specialization of 'value' in class scope
  bool value() const {
       ^
/repo/open_spiel/../open_spiel/game_parameters.h:137:47: error: explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/repo/open_spiel/../open_spiel/game_parameters.h:141:40: error: explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
In file included from /repo/open_spiel/matrix_game.cc:15:
In file included from /repo/open_spiel/../open_spiel/matrix_game.h:25:
In file included from /repo/open_spiel/../open_spiel/normal_form_game.h:24:
In file included from /repo/open_spiel/../open_spiel/simultaneous_move_game.h:22:
In file included from /repo/open_spiel/../open_spiel/spiel.h:36:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^
/repo/open_spiel/../open_spiel/game_parameters.h:121:10: error: explicit specialization of 'value' in class scope
  double value() const {
         ^
/repo/open_spiel/../open_spiel/game_parameters.h:125:22: error: explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/repo/open_spiel/../open_spiel/game_parameters.h:129:15: error: explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/repo/open_spiel/../open_spiel/game_parameters.h:133:8: error: explicit specialization of 'value' in class scope
  bool value() const {
       ^
/repo/open_spiel/../open_spiel/game_parameters.h:137:47: error: explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/repo/open_spiel/../open_spiel/game_parameters.h:141:40: error: explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
In file included from /repo/open_spiel/policy.cc:15:
In file included from /repo/open_spiel/../open_spiel/policy.h:25:
In file included from /repo/open_spiel/../open_spiel/spiel.h:36:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^
/repo/open_spiel/../open_spiel/game_parameters.h:121:10: error: explicit specialization of 'value' in class scope
  double value() const {
         ^
/repo/open_spiel/../open_spiel/game_parameters.h:125:22: error: explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/repo/open_spiel/../open_spiel/game_parameters.h:129:15: error: explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/repo/open_spiel/../open_spiel/game_parameters.h:133:8: error: explicit specialization of 'value' in class scope
  bool value() const {
       ^
/repo/open_spiel/../open_spiel/game_parameters.h:137:47: error: explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/repo/open_spiel/../open_spiel/game_parameters.h:141:40: error: explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
In file included from /repo/open_spiel/simultaneous_move_game.cc:15:
In file included from /repo/open_spiel/../open_spiel/simultaneous_move_game.h:22:
In file included from /repo/open_spiel/../open_spiel/spiel.h:36:
/repo/open_spiel/../open_spiel/game_parameters.h:117:7: error: explicit specialization of 'value' in class scope
  int value() const {
      ^

[lanctot]

Ah yes, we fixed this recently on the colab hosts as well. It is caused by old version of Clang that ships with Ubuntu 18.04. It is not caught by our Travis-CI tests because they use a newer version of clang.

I think the quick fix is to simply move to Ubuntu 20.04. That involves changing two lines in the Dockerfile:

1. Change the first line of the Dockerfile to 20.04.
2. You also have to add the -y to the apt-get install command in install.sh. See here for details: Ubuntu 20.04 Docker container #295

If this works for you I'd be happy if you submit a PR with an updated Ubuntu 20.04 image.

[lanctot]

I have fixed this and will be syncing to github shortly, thanks for reporting.

[andyljones]

If anyone else runs into this problem on Ubuntu 18, you can fix it with

apt-get install clang-10
ln -s $(which clang-10) /usr/bin/clang++