Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the common code about Heterogeneous Computing from module_psi to module_base #4095

Closed
8 tasks done
haozhihan opened this issue May 6, 2024 · 0 comments · Fixed by #4141
Closed
8 tasks done
Assignees
Labels
The Absolute Zero Reduce the "entropy" of the code to 0

Comments

@haozhihan
Copy link
Collaborator

Describe the Code Quality Issue

We can see that the code in module_psi/kernel folder is about common settings for heterogeneous computing. Not just for psi, but for all heterogeneous computing codes.

Therefore, we should put it at a lower level of architecture in abacus.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.
@haozhihan haozhihan added the Plans label May 6, 2024
@haozhihan haozhihan self-assigned this May 6, 2024
@haozhihan haozhihan changed the title Move the common code about Heterogeneous Computing under module_psi into module_base Move the common code about Heterogeneous Computing under module_psi into module_base May 6, 2024
@haozhihan haozhihan changed the title Move the common code about Heterogeneous Computing under module_psi into module_base Move the common code about Heterogeneous Computing from module_psi to module_base May 6, 2024
@haozhihan haozhihan added the The Absolute Zero Reduce the "entropy" of the code to 0 label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
1 participant