New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prepend_script and append_script for job.resource #273
Conversation
* add wait_time for resubmitted * fix the generation of empty logfile
For |
Codecov ReportBase: 58.63% // Head: 59.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 58.63% 59.44% +0.81%
==========================================
Files 26 27 +1
Lines 2879 2895 +16
==========================================
+ Hits 1688 1721 +33
+ Misses 1191 1174 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* add script rendering test for each part
Well, local test for script generation was add for Slurm, but not including |
Fixed. |
It is sometimes in need of executing command lines before or after task submitted to startup or shutdown necessary environment. While most issue with prepend script required like this might be solved by source a static script on remote server (which might also be difficult when remote server is not so stable.), scripts to be executed after tasks finished might be difficult under current dpdispatcher
resource
.Here in this PR,
prepend_script
andappend_script
parameters have been add tojob.resource
in form ofList
, in which a single line could be an item, like this:and the expected output:
Another little change is just add
delay=True
for logger to prevent the generation ofdpdispatcher.log
even if no log information output.