Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apex.amp support #126

Closed
BramVanroy opened this issue Oct 24, 2019 · 1 comment · Fixed by #133
Closed

Apex.amp support #126

BramVanroy opened this issue Oct 24, 2019 · 1 comment · Fixed by #133
Labels
enhancement New feature or request part: optimizer Optimizer part: trainer Trainer

Comments

@BramVanroy
Copy link
Contributor

BramVanroy commented Oct 24, 2019

Describe the solution you'd like
It would be great if Apex.amp is supported.

Additional context
If interested, I can work on this. I don't think it should be too much of a problem. I'd replace fp16 to amp instead of simply halfing everything.

@BramVanroy BramVanroy added the enhancement New feature or request label Oct 24, 2019
@tholor
Copy link
Member

tholor commented Oct 24, 2019

Hey @BramVanroy,

Great idea! Apex.amp seems much more user friendly & powerful. I was always a bit annoyed of all specialties introduced into the code by apex fp16 - and the drop in performance ;)

We would highly appreciate, if you could work on this and raised a PR. It should be mainly changes in the Trainer and in initialize_optimizer(). I am also happy to support in case any questions pop up.

After a quick look, I also realized that the current implementation of fp16 in the master branch is not compatible with the latest apex version anyway.

Instead of fixing this we should directly move to apex.amp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request part: optimizer Optimizer part: trainer Trainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants