Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Messages / Logs #590

Closed
10 of 11 tasks
Timoeller opened this issue Oct 16, 2020 · 0 comments
Closed
10 of 11 tasks

Improve Error Messages / Logs #590

Timoeller opened this issue Oct 16, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Timoeller
Copy link
Contributor

Timoeller commented Oct 16, 2020

We can improve Error messages to be more informative. This is a non comprehensive list, feel free to add incomprehensible error messages in the issue thread:

Prio 1

  • Only show for real download: "Could not find deepset/roberta-base-squad2 locally. Try to download from model hub ..."
  • Remove: "WARNING - farm.modeling.language_model - Could not automatically detect from language model name what language]it is. ..."
  • Error if no labels are produced by processor at training time (probably together with a ascii overview of connections between PH and tasks)
  • when passing in an empty list as label list it breaks. passing anything (not matching the labels or even the number of different labels present in data) makes it work. This might brake things later on when evaluating (Run NER)
  • passing the wrong train filename produces a cryptic error message: ValueError: Unexpected character found when decoding 'true' (Try QA)
  • for QA: do not display all cases where answer text is not euqals answer position. Print out stats how many examples could not be converted and maybe the ids
  • deprecate message for inference_from_objects (when we call inference from haystack) (don't call inference_from_objects in haystack)
  • Move unimportant messages from info to debug level
  • Reduce logged samples from 2 per dataloader (train,dev,test) to 1x for train and 1x for dev

Prio 2:

  • "Could not convert labels to ids via label_list!
  • If your are running in inference mode: Don't worry!" is displayed for every sample in NER inference mode. Lets find a switch to display it only once.
@Timoeller Timoeller added the enhancement New feature or request label Oct 16, 2020
@tholor tholor changed the title Improve Error Messages Improve Error Messages / Logs Nov 4, 2020
@tholor tholor added this to the #4 milestone Nov 4, 2020
@tholor tholor modified the milestones: #4, #5 Nov 18, 2020
@brandenchan brandenchan reopened this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants