Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test on tutorials #197

Closed
bilgeyucel opened this issue May 31, 2023 · 4 comments · Fixed by #224
Closed

Update test on tutorials #197

bilgeyucel opened this issue May 31, 2023 · 4 comments · Fixed by #224
Assignees
@silvanocerza @bilgeyucel
Labels
enhancement New feature or request

Comments

@bilgeyucel
Copy link
Contributor

This should be done once this PR deepset-ai/haystack#5028 is merged and we have base images with every release.

  • Add metadata to each tutorial to set on which image it should be tested
  • Run nightly test on these versions
  • Run nightly tests on main as well to be cautious about upcoming changes
  • Release images should be used when a tutorial is created or updated (on PRs)

Any other ideas @silvanocerza?
@bilgeyucel bilgeyucel added the enhancement New feature or request label May 31, 2023
@masci masci mentioned this issue Jun 1, 2023
Closed
6 tasks
@bilgeyucel bilgeyucel mentioned this issue Jun 6, 2023
Closed
@julian-risch julian-risch added the P1 label Jul 5, 2023
@bilgeyucel
Copy link
Contributor Author

Our decision after our sync

  • PRs: latest version & pinned versions (not main)
  • Nightly: latest version & pinned versions + main

@bilgeyucel
Copy link
Contributor Author

bilgeyucel commented Jul 23, 2023 •
edited
Loading

  • Add API Keys to Github
  • Mark some tutorials with needs_gpu

@bilgeyucel bilgeyucel mentioned this issue Jul 23, 2023
Merged
@silvanocerza silvanocerza reopened this Jul 24, 2023
@silvanocerza
Copy link
Contributor

Reopening as we still need to run tutorials on PRs.

@TuanaCelik TuanaCelik reopened this Aug 2, 2023
@julian-risch julian-risch removed the P1 label Sep 11, 2023
@bilgeyucel
Copy link
Contributor Author

bilgeyucel commented Jan 22, 2024 •
edited
Loading

Current TODOs for this issue:

Tasks

@silvanocerza silvanocerza self-assigned this Feb 26, 2024
This was referenced Mar 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silvanocerza silvanocerza

@bilgeyucel bilgeyucel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tutorials on latest Haystack version + on main deepset-ai/haystack-tutorials
4 participants
@silvanocerza @julian-risch @TuanaCelik @bilgeyucel