Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest haystack requires python 3.8 upwards? #155

Closed
predoctech opened this issue Jun 17, 2020 · 1 comment · Fixed by #156
Closed

Latest haystack requires python 3.8 upwards? #155

predoctech opened this issue Jun 17, 2020 · 1 comment · Fixed by #156
Assignees

Comments

@predoctech
Copy link

Typically I followed the installation recommendation and install haystack by:

git clone https://github.com/deepset-ai/haystack.git
cd haystack
pip install --editable .

This works until maybe a couple of days ago when there are changes to the dependency of 'Literal" from 'typing_extensions'. From internet search it seems like that is only supported from python v3.8 upwards. The first hit on that in my case is in /content/haystack/haystack/retriever/elasticsearch.py

I am developing my Haystack code in Google Colab and its python base is still v3.6.9. So the code failed at the early import library stage. What is the best way to get around such python dependencies?

@tanaysoni
Copy link
Contributor

Hi @predoctech, thank you for raising the issue. The Literal type hint is removed by #156, so it should now work in Colab notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants