Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document_id missing in FARMReader predict return statement #173

Closed
Timoeller opened this issue Jun 24, 2020 · 0 comments · Fixed by #174
Closed

document_id missing in FARMReader predict return statement #173

Timoeller opened this issue Jun 24, 2020 · 0 comments · Fixed by #174
Assignees
Labels
type:bug Something isn't working

Comments

@Timoeller
Copy link
Contributor

The error is coming from FARM inferencer. The document_id is missing in the returned json.

Currently this breaks our evaluation.
Tutorial5_Evaluation.py needs a document_id coming back from FARM.
Haystack eval first checks weather the document_id is corresponding to the gold truth, then it checks if the answer string is correct. Since the document_id coming back from FARM is None it never enters the answer string check.


input to the FARM inferencer is a dict:

cur = {
                "text": doc.text,
                "questions": [question],
                "document_id": doc.id
            }

output of farm inferencer has set document_id in all cases to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant