-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make a default yaml for user params #49
Comments
Which part of the yaml file should be protected and almost never changed? I'm guessing this is the universal constants? When we decide that, we can hide those constants somewhere. |
For most universal constants we are using built-in ones from astropy etc., it looks like right now it's just T_CMB in the .yaml and I don't think there's motivation to hide this (what if someone wants to toggle it?) |
the base_config.yaml has the constants we might want to hide. They were explicitly defined in config.yaml, so I wasn't sure if they should be kept or assumed. |
We needed the base_config.yaml in DeepCMBSim, because CAMB requires a bunch of parameter choices that we don't want users to have to make. We may not need that here. I'm not sure. |
I'm not familiar with the code on dev-pipeline as I've only been working on dev-massdist (other branches are stale) and I don't have a base_config.yaml I've been working with, I'm using astropy for fundamental constants (has unit capabilities) and not defining them in a yaml |
I will close this. When we define the input yaml config, we should take care to note if there are any parameters that should be defined, but that we don't want the user to have to mess with. |
The text was updated successfully, but these errors were encountered: