Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a default yaml for user params #49

Closed
3 tasks
bnord opened this issue May 4, 2023 · 8 comments
Closed
3 tasks

make a default yaml for user params #49

bnord opened this issue May 4, 2023 · 8 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@bnord
Copy link
Contributor

bnord commented May 4, 2023

  • look through the current config yaml
  • what part of that do we actually want the user to mess with
  • differentiate between what should be changed by the user and what shouldn't (e.g., speed of light vs. omega matter)
@bnord bnord added the question Further information is requested label Jun 18, 2023
@bnord bnord added this to the alpha release milestone Jun 18, 2023
@bnord
Copy link
Contributor Author

bnord commented Jun 18, 2023

Which part of the yaml file should be protected and almost never changed?

I'm guessing this is the universal constants?

When we decide that, we can hide those constants somewhere.

@bnord
Copy link
Contributor Author

bnord commented Jun 18, 2023

@evavagiakis
Copy link
Collaborator

For most universal constants we are using built-in ones from astropy etc., it looks like right now it's just T_CMB in the .yaml and I don't think there's motivation to hide this (what if someone wants to toggle it?)

@bnord
Copy link
Contributor Author

bnord commented Jun 19, 2023

the base_config.yaml has the constants we might want to hide. They were explicitly defined in config.yaml, so I wasn't sure if they should be kept or assumed.

@bnord
Copy link
Contributor Author

bnord commented Jun 19, 2023

@bnord
Copy link
Contributor Author

bnord commented Jun 19, 2023

We needed the base_config.yaml in DeepCMBSim, because CAMB requires a bunch of parameter choices that we don't want users to have to make.

We may not need that here. I'm not sure.

@evavagiakis
Copy link
Collaborator

I'm not familiar with the code on dev-pipeline as I've only been working on dev-massdist (other branches are stale) and I don't have a base_config.yaml I've been working with, I'm using astropy for fundamental constants (has unit capabilities) and not defining them in a yaml

@bnord
Copy link
Contributor Author

bnord commented Jun 19, 2023

I will close this.

When we define the input yaml config, we should take care to note if there are any parameters that should be defined, but that we don't want the user to have to mess with.

@bnord bnord closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants