DeepSkyStacker crashes in Wine, maybe due to missing TaskbarButton implementation in Wine and missing null pointer check in DSS.

[bernhardu]

Hello, I tried to do a little investigation about a Wine bug about DeepSkyStacker.
This might be related to the source lines below. I assume that in DSS recognises in Wine a Windows 7,
but m_taskbarList seems to get set to NULL as there seems to be not yet an implemtation of TaskbarButton in Wine,
which later gets called in OnProgressInit/OnProgressUpdate/OnProgressStop and therefore leads to a crash.
If this is right, this crash could be avoided by just checking m_taskbarList to be a valid pointer.

DSS/DeepSkyStacker/DeepStackerDlg.cpp

Line 132 in 11eb036

UINT WM_TASKBAR_BUTTON_CREATED = ::RegisterWindowMessage(_T("TaskbarButtonCreated"));

DSS/DeepSkyStacker/DeepStackerDlg.cpp

Line 170 in 11eb036

ON_REGISTERED_MESSAGE(WM_TASKBAR_BUTTON_CREATED, &CDeepStackerDlg::OnTaskbarButtonCreated)

DSS/DeepSkyStacker/DeepStackerDlg.cpp

Lines 346 to 355 in 11eb036

	LRESULT CDeepStackerDlg::OnTaskbarButtonCreated(WPARAM /*wParam*/, LPARAM /*lParam*/)
	{
	if (IsWindows7OrGreater())
	{
	HRESULT hr = ::CoCreateInstance(CLSID_TaskbarList, nullptr, CLSCTX_INPROC_SERVER, IID_ITaskbarList3, reinterpret_cast<void**>(&m_taskbarList));
	if (FAILED(hr))
	return 0;
	hr = m_taskbarList->HrInit();

DSS/DeepSkyStacker/DeepStackerDlg.cpp

Lines 362 to 366 in 11eb036

	LRESULT CDeepStackerDlg::OnProgressInit(WPARAM /*wParam*/, LPARAM /*lParam*/)
	{
	if (IsWindows7OrGreater())
	{
	m_taskbarList->SetProgressState(m_hWnd, TBPF_NORMAL);

[Crazor]

Just wanting to let people that come across this bug know that as stated in the WineHQ link, changing the Wrapper from Windows 7 to Windows XP works just fine.

[perdrix52]

WIne isn't supported