Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle value class #12

Closed
glureau opened this issue Feb 7, 2022 · 1 comment
Closed

Handle value class #12

glureau opened this issue Feb 7, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@glureau
Copy link
Collaborator

glureau commented Feb 7, 2022

0.1.1 release actually consider value class as a class:

  • if you don't use the annotation on this class, other classes will expect a generated class with the name of the value class, but it doesn't exist
  • if you do use the annotation, as it considers it as a class, it'll not work, or generate boilerplate and that's not what we expect from a value class

I think we should generate a typealias for annotated value class, so that it's closer to the expected output of a value class.

@glureau glureau added the enhancement New feature or request label Feb 7, 2022
@glureau glureau self-assigned this Feb 8, 2022
@glureau
Copy link
Collaborator Author

glureau commented Feb 8, 2022

Fixed by 0bfcd96
Available in 0.2.0

@glureau glureau closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant