Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Exception support? #20

Closed
glureau opened this issue Mar 30, 2022 · 1 comment
Closed

Remove Exception support? #20

glureau opened this issue Mar 30, 2022 · 1 comment
Assignees

Comments

@glureau
Copy link
Collaborator

glureau commented Mar 30, 2022

A previous experimentation has been pushed on Exceptions.

It was practical for our use case at the time but it's leading to more and more subtle issues that we don't want to support. Also it worked only when passing the exception in a method/property, but it cannot be wrapped when a throw is done from Typescript, meaning that a try/catch on the Kotlin will still have to deal with the Typescript Error and not the wrapped exception.

From our learnings, we think it's better to have explicit API with types that don't extends Exception. And if we need to pass it, we'll let KotlinJs deal with it and not trying to interfere here. But for that we need #19 and #17 to be fixed.

As a bonus, it should also reduce the bundle size.

@glureau glureau self-assigned this Mar 30, 2022
@glureau glureau changed the title Remove Exception support Remove Exception support? Apr 5, 2022
@glureau
Copy link
Collaborator Author

glureau commented Apr 19, 2022

Exceptions are no more handled by KustomExport, starting from v0.5.0

@glureau glureau closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant