Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sealed class #21

Closed
glureau opened this issue Apr 14, 2022 · 1 comment
Closed

Sealed class #21

glureau opened this issue Apr 14, 2022 · 1 comment
Assignees
@glureau
Milestone
0.4.2

Comments

@glureau
Copy link
Collaborator

glureau commented Apr 14, 2022 •
edited

Exporting sealed class with KotlinJs make the code executable but not compliant with strict typescript rules. (The generated class is not abstract but with abstract fields for example, creating issues on typescript.)

https://youtrack.jetbrains.com/issue/KT-39193

We could generate an abstract class instead: the sealed is important for Kotlin side, but it has no class hierarchy limitation on the JS/TS word, so it's probably nothing more than an abstract class for the facade.
@glureau glureau self-assigned this Apr 14, 2022
@glureau glureau mentioned this issue Apr 15, 2022
Merged
@glureau glureau added this to the 0.4.2 milestone Apr 15, 2022
@glureau
Copy link
Collaborator Author

glureau commented Apr 15, 2022

Released in 0.4.2

@glureau glureau closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glureau glureau

Labels
None yet
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@glureau