Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move package create/deploy warnings to the package confirmation warnings section #1722

Closed
Racer159 opened this issue May 17, 2023 · 0 comments · Fixed by #1749
Closed

Move package create/deploy warnings to the package confirmation warnings section #1722

Racer159 opened this issue May 17, 2023 · 0 comments · Fixed by #1749
Assignees
@Racer159
Labels
enhancement ✨ New feature or request ga Issues tracking toward Zarf 1.0 ux
Milestone
v0.27 (m2-5.23)

Comments

@Racer159
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Move any package warnings to the warnings section of the Package confirmation screen.

As Ashton I want to see warnings related to my package in the warnings section of the package confirmation screen so that I can review them all together and am more likely to notice them.

Describe the solution you'd like

  • Given I have a package or package configuration that will generate warnings
  • When I run a Zarf command that requires confirmation (create or deploy)
  • Then Zarf will display those warnings in the warnings section of the package confirmation prompt

Additional context

Below is an example of a package-related warning that appears before the prompt (needs to move):
image

Below is an example of a package warning in the warnings section:
image

Existing warnings should simply move to that section without an increase in verbosity.
@Racer159 Racer159 added enhancement ✨ New feature or request ux ga Issues tracking toward Zarf 1.0 labels May 17, 2023
@Racer159 Racer159 added this to the v0.27 (m2-5.23) milestone May 17, 2023
@Racer159 Racer159 self-assigned this May 22, 2023
This was referenced May 22, 2023
Closed
Merged
Racer159 added a commit that referenced this issue May 31, 2023
@Racer159 @YrrepNoj
Initial package warnings section and unhide filtered components (#1749)
2571a71 
## Description

This moves any deprecated package warnings into the warnings section of
the Zarf confirm page.
And updates SBOM section language, colors, and UX

## Related Issue

Fixes #1722
Fixes #1752
Fixes #1751 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Jonathan Perry <YrrepNoj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
enhancement ✨ New feature or request ga Issues tracking toward Zarf 1.0 ux
Projects
None yet
Milestone
v0.27 (m2-5.23)
Development

Successfully merging a pull request may close this issue.

Initial package warnings section and unhide filtered components zarf-dev/zarf
1 participant
@Racer159