Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when provided variables are unused #2096

Open
YrrepNoj opened this issue Oct 24, 2023 · 0 comments
Open

Warn when provided variables are unused #2096

YrrepNoj opened this issue Oct 24, 2023 · 0 comments
Labels
enhancement ✨ New feature or request
Milestone

Comments

@YrrepNoj
Copy link
Member

When deploying (or creating) a Zarf package, users are able to set variables via the --set flag. If the variable a user is trying to set is not used by the package, a warning should be logged when the user gets to the confirmation dialog.

When I ran the command zarf package deploy {PACKAGE} --set=ENABLE_GPU=true I got the following result.
I almost missed that the ENABLE_GPUS variable was still values because I misspelled the value when typing the command.
Screen Shot 2023-10-24 at 12 45 19 PM

Describe the solution you'd like

When a variable is provided via the --set flag. I would like a warning if the variable did not actually exist in the config.

Screen Shot 2023-10-24 at 12 50 28 PM

Describe alternatives you've considered

Variables that are provided via the zarf-config.yaml might be the exception to this request since. Unsure how the team wants handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants