Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerations/NodeSelector for Zarf registry #2176

Open
docandrew opened this issue Dec 4, 2023 · 3 comments
Open

Tolerations/NodeSelector for Zarf registry #2176

docandrew opened this issue Dec 4, 2023 · 3 comments
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers k8s

Comments

@docandrew
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We'd like to be able to add a NodeSelector and tolerations to the Zarf registry via deployment variables for the zarf init command with --set. The immediate need driving this request is to work around #2104, but I think other users would benefit by being able to fine-tune their registry placement or enable the use of Zarf on nodes already tainted for different reasons.

Describe the solution you'd like

  • Modify the Zarf registry charts to allow templating of the nodeSelector and tolerations keys in the spec.
  • Add Zarf variables the Zarf registry zarf.yaml to enable setting these w/ --set during zarf init.

Describe alternatives you've considered

Manual modification and/or deployment of custom zarf init package with these set, or patching the registry manifests post-deployment.

@docandrew docandrew added the enhancement ✨ New feature or request label Dec 4, 2023
@Racer159 Racer159 added the good first issue 🥇 Good for newcomers label Jan 25, 2024
@Racer159
Copy link
Contributor

@lemonprogis
Copy link

lemonprogis commented Mar 7, 2024

Hello 👋, @docandrew. I would like to pick this issue up if it's available.

@lemonprogis
Copy link

Nevermind, I see @waveywaves got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers k8s
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

4 participants