Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sboms.tar being created with extra empty file #2218

Open
decleaver opened this issue Jan 8, 2024 · 2 comments
Open

sboms.tar being created with extra empty file #2218

decleaver opened this issue Jan 8, 2024 · 2 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@decleaver
Copy link
Contributor

Describe what should be investigated or refactored

The sboms.tar file is being created with extra empty file when doing a zarf package create. Can be recreated by

Links to any relevant code

name, err := filepath.Rel(dirPath, filePath)

(Potential fix) In the CreateReproducibleTarballFromDir function a check can be made if the dirPath and filePath are equal to not write the empty header.

Additional context

It was mentioned that there are other parts of the code base where empty/unnecessary files are being written to zarf packages.

@decleaver decleaver added the tech-debt 💳 Debt that the team has charged and needs to repay label Jan 8, 2024
@Racer159
Copy link
Contributor

Racer159 commented Jan 8, 2024

We should also address the empty zarf-<number> folders as well during this.

@Racer159 Racer159 added this to the The Bucket milestone Feb 6, 2024
@Racer159
Copy link
Contributor

Here is what I mean by that folder:
image
There is a straggling zarf- folder in most Zarf packages that shouldn't be there.

@salaxander salaxander removed this from the The Bucket milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

3 participants