Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: configure log file prefix #2524

Closed
UncleGedd opened this issue May 21, 2024 · 0 comments · Fixed by #2545
Closed

lib: configure log file prefix #2524

UncleGedd opened this issue May 21, 2024 · 0 comments · Fixed by #2545
Labels
enhancement ✨ New feature or request

Comments

@UncleGedd
Copy link
Contributor

Is your feature request related to a problem? Please describe.

UDS CLI uses Zarf as a lib to deploy packages, and we'd like to be able to set the log prefix when configuring logs

Describe the solution you'd like

  • Given a user is using UDS CLI to deploy a Zarf pkg
  • When the user deploys the app
  • Then the generated log file start with uds as opposed to zarf
@UncleGedd UncleGedd added the enhancement ✨ New feature or request label May 21, 2024
@Noxsios Noxsios mentioned this issue May 23, 2024
Merged
2 tasks
@Noxsios Noxsios linked a pull request May 23, 2024 that will close this issue
refactor: allow callers to directly set logfile location #2545
Merged
2 tasks
Noxsios added a commit that referenced this issue May 23, 2024
@Noxsios
refactor: allow callers to directly set logfile location (#2545)
f003c94 
Changes `message.UseLogFile` to accept an `f *os.File` and wrap it in a
`*message.PausableWriter`. Adds unit tests for `PausableWriter`.

## Related Issue

Fixes #2524 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Signed-off-by: razzle <harry@razzle.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: allow callers to directly set logfile location zarf-dev/zarf
1 participant
@UncleGedd