Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarf adds package to package list even if deployment fails #2701

Open
Ansible-man opened this issue Jul 8, 2024 · 3 comments
Open

Zarf adds package to package list even if deployment fails #2701

Ansible-man opened this issue Jul 8, 2024 · 3 comments

Comments

@Ansible-man
Copy link

Environment

Device and OS: RHEL 9
App version: 0.35.0
Kubernetes distro being used: RKE2
Other:

Steps to reproduce

  1. Deploy a Zarf package
  2. CTRL+C the deployment (you would do this if its hung on the deployment for whatever reason)
  3. Check output of zarf packages

Expected result

Zarf cleans up and the package list does not contain the failed deployment unless the package deploys successful

Actual Result

Zarf adds the package to the package list

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

low

Additional Context

Cursor also disappears until entire terminal is closed and reopened

@phillebaba
Copy link
Member

I think this is more of a feature than a bug. We want to record all packages that have been deployed no matter if they have succeeded or not. Otherwise we would not be able to remove the packages after the cancelled attempt.

There is however merit in discussing if adding this as a feature to automatically remove packages if the process is cancelled. It does however come with a lot of caveats as to how to deal with version upgrades and so on.

Your cursor issue that you are seeing is a known issue that will hopefully be solved during our structured logging refactoring.

@Ansible-man
Copy link
Author

Maybe the feature could add another collum to the output of zarf package list that shows the deployment status? We also have a use case to track the last patch date in a similar fashion but currently implementing a custom solution for that.

@phillebaba
Copy link
Member

I think adding an additional column is a great idea, makes things more clear to the end user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants