-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema docs to include information about OCI registries for helm charts #1464
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@lucasrod16 looks like you need to run |
@Racer159 Ahh I see, thanks! Is the purpose of that to ensure that all of the right references got updated when there's an update to the docs? I can add that step and describe when it should be used to the |
@Racer159 when I'm running |
@lucasrod16 yeah the reason it cuts it off is because the values there are comma separated - to do a description with commas you have to use And if you can add a reference to that in the contributing guide that would be great! The purpose of |
Use jsonschema_description in struct tag to allow commas in string
@Racer159 Thanks! I made the |
@Racer159 this is ready for review whenever you get the chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny suggestion but figured more info could be valuable (in case someone ran into this on our command docs too)
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks!
Description
Related Issue
Fixes #1463
Type of change
Checklist before merging