Change zarf init to always install the docker registry

[jeff-mccoy]

No description provided.

[jeff-mccoy]

Seen this behavior in some restricted environments too, so just removing for now because it doesn't really do anything for us. That, and it failed the E2E with the new mirroring setup:
https://repo1.dso.mil/platform-one/big-bang/apps/product-tools/zarf/-/jobs/7058776.

[RothAndrew]

@jeff-mccoy in cli/internals/util/pki.go

Change

if ip := net.ParseIP(host); ip != nil {
  template.IPAddresses = append(template.IPAddresses, ip)
} else {
  // Add localhost to make things cleaner
  template.DNSNames = append(template.DNSNames, host, "localhost", config.ZarfLocal, "*.localhost")
  if template.Subject.CommonName == "" {
    template.Subject.CommonName = host
  }
}

to

// We need to add `config.ZarfLocal` to the certificate, but the way to do that is different depending on whether it
// is a DNS name or a IP address. This really shouldn't be necessary since `config.ZarfLocal` is a const, but it
// lets us mess with the value of that const without having to change logic in this function
if ip := net.ParseIP(config.ZarfLocal); ip != nil {
  // config.ZarfLocal is an IP address
  template.IPAddresses = append(template.IPAddresses, ip)
  } else {
    // config.ZarfLocal is assumed to be a DNS name
    template.DNSNames = append(template.DNSNames, config.ZarfLocal)
  }

if ip := net.ParseIP(host); ip != nil {
  template.IPAddresses = append(template.IPAddresses, ip)
  } else {
    // Add localhost to make things cleaner
    template.DNSNames = append(template.DNSNames, host, "localhost", "*.localhost")
    if template.Subject.CommonName == "" {
      template.Subject.CommonName = host
  }
}

I have this staged if you'd like me to push it, or you can adjust to your style if you want.

[jeff-mccoy]

Finally ugh, passing e2e: https://repo1.dso.mil/platform-one/big-bang/apps/product-tools/zarf/-/jobs/7102636

[RothAndrew]

I'm seeing the error again about IP SANs, not sure why. still investigating

Edit: Nevermind, I forgot to git pull

[jeff-mccoy]

That’s sounds like something I would do…. 😂

[RothAndrew]

Other than the Repo1 comment LGTM

[jeff-mccoy]

Changes made and E2E passing: https://repo1.dso.mil/platform-one/big-bang/apps/product-tools/zarf/-/pipelines/515560

[RothAndrew]

@jeff-mccoy can we delete this branch?