[question] hardhat config

[alxiong]

1. why manually probing into hardhat/types::HardhatUserConfig and declaring the outputSelection rather awkwardly here, instead of using hardhat-storage-layout plugin
2. where in the code did we try to update a storage slot in the example code or test?

[alxiong]

Ah! I think I was mistaken, we were not intending to use hardhat-storage-layout plugin, but rather smock instead, correct?

Nevertheless, should have stick to:

const config = {
  solidity: {
    settings: {
      outputSelection: {
        "*": {
          "*": ["storageLayout"]
        }
      }
    }
  }
}

instead of

  (config.solidity as MultiSolcUserConfig).compilers = (config.solidity as MultiSolcUserConfig).compilers.map((compiler) => {
    return {
      ...compiler,
      outputSelection: {
        '*': {
          '*': ['storageLayout'],
        },
      },
    };
  });

[alxiong]

More questions/comments:

possible updates to hardhat.config.ts to consider:

1. addgasReporter.excludeContracts: ['contracts/mocks/']

puzzling devDependencies:

1. when is moment ever used? plus the package is in maintenance mode

[404skillz]

@alxiong thanks for all the input ! It got lost on my notifications. Will look into all of them and ping you back !

[turtlemoji]

More questions/comments:

possible updates to hardhat.config.ts to consider:

1. addgasReporter.excludeContracts: ['contracts/mocks/']

puzzling devDependencies:

1. when is moment ever used? plus the package is in maintenance mode

• Moment is removed in current main
• Agree with the gas reporter
  Now it should be excludeContracts: ['solidity/mocks/'], @alxiong

[0xged]

hey guys! in terms of the contract exclusion of mocks, the bad thing is that if you test against mocks contracts you will not have any of your tests in the coverage.

[turtlemoji]

@0xged True, closing for now then.