Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependency issues #402

Closed
brenopolanski opened this issue Jun 15, 2022 · 0 comments
Closed

Circular dependency issues #402

brenopolanski opened this issue Jun 15, 2022 · 0 comments

Comments

@brenopolanski
Copy link
Contributor

There are some circular dependency issues in defillama-app.

Circular dependencies (also known as cyclic dependencies) occur when two or more modules reference each other.
ref: https://spin.atomicobject.com/2018/06/25/circular-dependencies-javascript/

To detect this problem, I added the next-circular-dependency to next.config.js.

Circular dependency detected:
src/components/Charts/DominanceChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/DominanceChart.tsx

Circular dependency detected:
src/components/Charts/PeggedDominanceChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PeggedDominanceChart.tsx

Circular dependency detected:
src/components/Charts/PeggedPieChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PeggedPieChart.tsx

Circular dependency detected:
src/components/Charts/PieChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PieChart.tsx

Circular dependency detected:
src/components/Charts/index.tsx -> src/components/Charts/PieChart.tsx -> src/components/Charts/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brenopolanski