Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript definition duplication hell #5

Closed
extrawurst opened this issue Oct 18, 2012 · 3 comments
Closed

typescript definition duplication hell #5

extrawurst opened this issue Oct 18, 2012 · 3 comments

Comments

@extrawurst
Copy link

Hi nice definitions you have here, but don't you think we should try to not duplicate stuff like nodejs defs ? look over here: github.com/soywiz/typescript-node-definition
@borisyankov
Copy link
Member

The original node.js definitions are created by the TypeScript's team. Both mine and soywiz's come from there.

@extrawurst
Copy link
Author

Yeah but yours does not contain the fixes we did, right ?

On Thu, Oct 18, 2012 at 3:14 PM, Boris Yankov notifications@github.comwrote:

The original node.js definitions are created by the TypeScript's team.
Both mine and soywiz's come from there.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-9563739.

@borisyankov
Copy link
Member

No. And neither contain the fixes from the original authors, since the initial commit.
The ideal solution would be for you to do a pull request for your fixes to TypeScript's project.

johnnyreilly pushed a commit that referenced this issue Jan 22, 2015
@vsiao
Merge pull request #5 from borisyankov/master
82f0c65 
Merge borisyankov:master into Asana:master
vvakame pushed a commit that referenced this issue Feb 20, 2015
@bluong
Merge pull request #5 from borisyankov/master
9f2d187 
Update fork
lattwood pushed a commit to NickelMedia/DefinitelyTyped that referenced this issue Jan 20, 2016
@aldrinleal
Merge pull request DefinitelyTyped#5 from ingenieux/return-requests
21b73b8 
Return AWS.Request values for all operations
ojha-ravi pushed a commit to ojha-ravi/DefinitelyTyped that referenced this issue Jun 17, 2016
@myitcv
Merge pull request DefinitelyTyped#5 from subash-a/fetch-api-fix
48f9a8a 
BodyInit definition needs to be modified
ghost pushed a commit that referenced this issue Sep 21, 2016
@TonyPythoneer
Merge pull request #5 from DefinitelyTyped/master
2698720 
Update master
zhengbli pushed a commit that referenced this issue Oct 20, 2016
@christophercr
Merge pull request #5 from DefinitelyTyped/master
fe91970 
Pull latest changes from head
zhengbli pushed a commit that referenced this issue Nov 1, 2016
@StefH
Merge pull request #5 from DefinitelyTyped/types-2.0
6d70301 
Merge latests from Types 2.0 (2016-10-23)
amcasey pushed a commit that referenced this issue Aug 8, 2017
@smac89
Merge pull request #5 from DefinitelyTyped/master
e6eac62 
Merge upstream
sandersn pushed a commit that referenced this issue Sep 7, 2017
@dolanmiu
Merge pull request #5 from DefinitelyTyped/master
d7d24ea 
Update to latest
mhegazy pushed a commit that referenced this issue Sep 25, 2017
@zspitz @mhegazy
Microsoft Office (Desktop) via Automation (#19987)
73dd199 
* Merge updates (#4)

* Merge upstream updates (#5)

* Initial commit for MS OFfice Automation

* Modified activex-excel and tests; activex-msforms

* ADODB tests, DAO tests

* msforms, msxml, mshtml

* MSXML tests

* Office, VBIDE, Word

* Word

* Word

* Outlook, Powerpoint

* Added project URL for stdole

* Added 'private' to package.json

* activex-adodb fixes

* remove public member-access

* activex-adodb fixes

* activex-adodb tests fixes

* activex-adodb-tests fix

* activex-adodb-tests fix -- no-unnecessary-generics

* remove public modifier

* TravisCI fixes

* More TravisCI fixes

* More TravisCI fixes
DanielRosenwasser pushed a commit that referenced this issue May 22, 2018
@Rick-Kirkham
Merge pull request #5 from Rick-Kirkham/AlexJ-Migration-Cleanup
818d3f6 
Alex j migration cleanup
amcasey pushed a commit that referenced this issue Oct 2, 2018
Merge pull request #5 from DefinitelyTyped/master
1190547 
Updating my own fork
weswigham pushed a commit that referenced this issue Dec 25, 2018
@nkappler
Merge pull request #5 from DefinitelyTyped/master
c17a0c3 
keep fork up to date
uniqueiniquity pushed a commit that referenced this issue Apr 10, 2019
@PopGoesTheWza
Merge pull request #5 from DefinitelyTyped/master
1ccf5a7 
sync
@peterblazejewicz peterblazejewicz mentioned this issue Apr 23, 2020
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@extrawurst @borisyankov