Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Knockout definition breaks subscribe on KnockoutObservableAny #57

Closed
niemyjski opened this issue Nov 7, 2012 · 3 comments
Closed

Latest Knockout definition breaks subscribe on KnockoutObservableAny #57

niemyjski opened this issue Nov 7, 2012 · 3 comments

Comments

@niemyjski
Copy link
Contributor

No description provided.

@niemyjski
Copy link
Contributor Author 

 public get range() : KnockoutObservableAny {
        return this._selectedrange;
    }

You can no longer do range.subscribe(x: MyType)... It has to be of any now..

@ajorkowski
Copy link

I have added a test and fixed with 5166fa4. The subscribe call should also be typed if you use one of the typed versions of observable etc

@niemyjski
Copy link
Contributor Author

Thanks!

@halostatue halostatue mentioned this issue Oct 3, 2021
Closed
12 tasks
nickmccurdy pushed a commit to nickmccurdy/DefinitelyTyped that referenced this issue Oct 29, 2022
@basarat
Merge pull request DefinitelyTyped#57 from martov1/patch-1
3ae90b9 
added ALM to the list of typescript IDEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niemyjski @ajorkowski