Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible documentation error: rebase() #624

Open
irondune opened this issue May 6, 2014 · 2 comments
Open

Possible documentation error: rebase() #624

irondune opened this issue May 6, 2014 · 2 comments

Comments

@irondune
Copy link

irondune commented May 6, 2014

The example for template function rebase() includes {{base}} as the insertion variable. This escapes the template contents and the example code fails to render properly. The variable should be {{!base}} instead.

@oz123
Copy link
Contributor

oz123 commented May 29, 2014

Hey! This is cool you wrote it here. I was about to report a bug on it. I thought the behavior of rebase is inconsitent with the documentation.
Indeed doing {{!base}} yields the expected behavior.

@oz123
Copy link
Contributor

oz123 commented May 29, 2014

This is already fixed in PR#615, now as commit ebe2e52. Oddly enough, the fix is not shown in the rendered docs. Or in github when clicking on the file stpl.rst.
I think this issue should be closed, and docs newly renderd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants