-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check against known badge URLs #7
Comments
@maxdeviant that is one approach tho I was hesitant to do that cause I would need to start maintaining a master list of badge URL (which may not be that terrible but seems like it could discourage use). I've actually been working on a solution which uses image analysis to determine if the actual image served by the URL is a badge. Maybe a combination of a URL master list and this technique can be used. Hoping to get improved recognition out this week so the readme regex hack can be removed since it is unreliable. |
Maintaining a master list doesn't sound like fun, but it's probably the simplest way. Image analysis would be a much cooler solution though 😄 |
Commented in #1 with progress. |
Should badginator check against known URLs for serving badges to prevent false positives (e.g., a non-badge PNG that links somewhere)?
The text was updated successfully, but these errors were encountered: