Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we put back the readonly connection? #42

Closed
peterjaap opened this issue Feb 2, 2023 · 2 comments
Closed

Can we put back the readonly connection? #42

peterjaap opened this issue Feb 2, 2023 · 2 comments

Comments

@peterjaap
Copy link
Contributor

I saw this in the code;

        /**
         * @todo: Had to remove the connectionByName = 'readonly' temporarily until readonly connection
         * is added to Magento Cloud Pro project by Magento Cloud support
         */

* @todo: Had to remove the connectionByName = 'readonly' temporarily until readonly connection

It's been 2 years, can we put it back?

@jantzenw
Copy link
Collaborator

Fixed in 3.0.0

@peterjaap
Copy link
Contributor Author

peterjaap commented May 30, 2023

@jantzenw this doesn't seem to be the case?

The readonly comment being removed is still there, and that's the only referenceo to readonly in the code base?

https://github.com/degdigital/magento2-customreports/blob/b51c2ac05020c21462af9158be33cbb68aebedf5/Model/GenericReportCollection.php#LL37C28-L37C28

Sorry, wrong branch, Github search throw me off. It is actually there; https://github.com/degdigital/magento2-customreports/blob/3.1.4/Model/GenericReportCollection.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants