Math-Magicians: events #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainsadaqat
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
APPROVED!!!! 🎉 🎉 🎉 🎉 🎉 🎉
Hey @degisew 😊 😃
Great Job 😄 👏 You've done it. Your project is complete! There is nothing else to say other than... it's time to merge it 👍🏻 ✅
Congratulations!!! 🎉 🥳 👏 🙌 🎊
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math-Magicians: events
In this PR, I implemented the following features:
I Copied the files calculate.js and operate.js into a logic/ directory in your project.
I added big.js as a dependency.
Imported the files in your Calculator component.
Implemented the event handlers that needed to use the math logic from calculate.js and operate.js in my React component.
I used state and props, passed props to child components, used lifecycle methods, lift the state up.