Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit version change #17

Closed
martinklepsch opened this issue Feb 13, 2016 · 4 comments
Closed

Commit version change #17

martinklepsch opened this issue Feb 13, 2016 · 4 comments

Comments

@martinklepsch
Copy link

When using the version change in combination with the push tasks ensure-clean option you can't use. Both in the same boot invocation. To avoid this it might be handy to commit the version properties change as part of the version task.

@burn2delete
Copy link
Member

Hey Martin,
I was thinking about this, maybe a check to see if the repo is already clean? If it is then commit the version change?

I noticed this also confused the git commit ID when the jar is built.

@martinklepsch
Copy link
Author

maybe a check to see if the repo is already clean?

Yeah I guess that makes sense then you get clean, tagged, no-change release commits.

I noticed this also confused the git commit ID when the jar is built.

How can it be confused if you're currently not making a commit? I don't think I understand 😄

@burn2delete
Copy link
Member

How can it be confused if you're currently not making a commit?

I think this might be a problem in my workflow, not the task itself.

Yeah I guess that makes sense then you get clean, tagged, no-change release commits.

Maybe boot.git should get a PR for write actions to the repo?

@burn2delete
Copy link
Member

@martinklepsch this is possible with boot-semgit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants