New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add line offset headers #42
Conversation
Useful for skipping rows in CSVs that have table titles
@dehesa I just wanted to check in and see if there's anything else I need to do with the PR for it to be merged in. Thanks! |
Hi @emorydunn First of all, I am very sorry I haven't looked into this 😔 My focus was on other projects and I didn't really noticed. I will check this week the PR and leave you some comments or accept it. In any case, I highly appreciate you putting in the time to contribute here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @emorydunn ,
Thank you for the contribution and the grammar changes. The PR looks good overall, I just left you some small comments. Also, please be sure to target the merge on the develop
branch.
Thanks for taking the time to review everything. I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @emorydunn. I just left a final comment.
Done and, again, I am sorry it took so long. |
Thanks, and don't worry about the timing, I'm happy to be able to contribute to a library I use so much |
Useful for skipping rows in CSVs that have table titles
Description
This PR adds a header strategy to parse headers from the specified row number, ignoring any previous row (and fixes a few typos). The change is additive, leaving the existing
.firstLine
option in place. I've been using the the header strategy in of of my own apps without any issues.The tests have been updated to include the new strategy by way of a table title, and all pass.
Checklist
The following list must only be fulfilled by code-changing PRs. If you are making changes on the documentation, ignore these.
develop
.