getXML() usage and enhancement

[GoogleCodeExporter]

Wanted to get this function clarified. getXML() seems to be a simple
wrapper for reading a XML file.

1. Should this be used more? Even functions like menu_data() the exact code
that is contained by getXML(). Should these be changed to getXML()?

2. Should it be enhanced to support addCData()? Currently the XML DOM load
by getXML() can not be manipulated with the help of addCData(). The fix
would be swapping:

   simplexml_load_string($xml, NULL, LIBXML_NOCDATA)

with:

   simplexml_load_string($xml, 'SimpleXMLExtended', LIBXML_NOCDATA)

Wanted to put this up for debate. As I have no good idea of how much we
actually use this function in the core.

Original issue reported on code.google.com by martijn.personal@gmail.com on 23 Feb 2010 at 10:07

[GoogleCodeExporter]

This function is used in the core quite extensively. Can you make that change 
and see
if it breaks anything? Since all the init xml files are read by that function 
it will
be pretty clear if this works or not.

Thanks Martijn

Original comment by ccagle8 on 23 Feb 2010 at 2:03

[GoogleCodeExporter]

So it was just menu_data() being behind on the rest of the core once more?

What a little bugger that function tends to be ;-) I will be on my PC with SVN 
set-up
in about an hour or so, will update the function and see whether menu_data() 
wants to
play along with it.

/Switching this ticket to me./

Original comment by martijn.personal@gmail.com on 23 Feb 2010 at 2:14

• Changed state: Accepted

[GoogleCodeExporter]

This should now be fixed. Might need some more testing but the code shouldn’t 
give to
much problems.

Original comment by martijn.personal@gmail.com on 23 Feb 2010 at 7:29

• Changed state: Fixed