Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Make --group mandatory #80

Closed
slack opened this issue Oct 26, 2015 · 6 comments
Closed

Make --group mandatory #80

slack opened this issue Oct 26, 2015 · 6 comments
Labels

Comments

@slack
Copy link
Contributor

slack commented Oct 26, 2015

We need to make sure folks who deploy more than one instance of a helm chart into a single namespace don't end up getting very confusing results.

For example, if I have two instances of redis-standalone in the default namespace and I use a simple label selector of provider=redis my application will be automatically load balanced between all redis instances.

We should probably make group=... parameter required.

@sgoings
Copy link
Contributor

sgoings commented Oct 27, 2015

I think adding a required parameter reduces a bit of the magic that a helm install gives users. If at all possible, we should have default commands (with no parameters) that "just work."

@bgrant0607
Copy link

Why not just use separate namespaces?

Related: kubernetes/kubernetes#1698

@gabrtv
Copy link

gabrtv commented Nov 5, 2015

Why not just use separate namespaces?

We do offer namespace parameterization. However, we also want to allow for multiple instances of a chart (Redis) to live in the same namespace. The group label convention allows for multiple providers to co-exist in the same namespace -- analogous to a tier label.

@technosophos
Copy link
Member

I am not totally convinced that we need to make group mandatory for Helm to work. This imposes an unnecessary burden on the simple-case user. It also enforces a part of "our model" that not all users will find they want to participate in.

I'd rather develop more of a use case than rush to implement this as described here.

@bgrant0607
Copy link

I'm supportive of adding some automatic label management to Kubernetes.

kubernetes/kubernetes#15390

@mboersma
Copy link
Contributor

mboersma commented Jun 1, 2016

The future of Helm is at kubernetes/helm. Helm Classic is in maintenance mode, so I'm closing this enhancement request.

@mboersma mboersma closed this as completed Jun 1, 2016
gabrtv pushed a commit to gabrtv/helm that referenced this issue Jun 30, 2016
Add resource state / errors to manifest. First step to helm#79, helm#80
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants